Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up LastTransitionTime in case that it is empty #1370

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Set up LastTransitionTime in case that it is empty #1370

merged 2 commits into from
Nov 13, 2023

Conversation

alvneiayu
Copy link
Collaborator

Description of the change

Set up LastTransitionTime in case that it is empty to avoid crashes setting up the Status:

Error updating SealedSecret namespace/mock-secret status: 
SealedSecret.bitnami.com "rnamespace/mock-secret" is invalid: 
status.conditions[0].lastTransitionTime: Invalid value: "null": 
status.conditions[0].lastTransitionTime in body must be of type string: "null"

Applicable issues

@alvneiayu alvneiayu force-pushed the statusemptylasttransitiontime branch from 7fc38b1 to 05ad86e Compare November 10, 2023 16:37
@tewfik-ghariani
Copy link
Contributor

I tested this quickly but it did not solve the issue ^^'

controller version: 05ad86ee34c818fcb1ab1bc175ba0a4c18b3d0b7
2023/11/10 17:30:56 Starting sealed-secrets controller version: 05ad86ee34c818fcb1ab1bc175ba0a4c18b3d0b7
Searching for existing private keys

Error updating SealedSecret playground-dev/mock-secret status: 
SealedSecret.bitnami.com "mock-secret" is invalid: 
status.conditions[0].lastTransitionTime: Invalid value: "null": 
status.conditions[0].lastTransitionTime in body must be of type string: "null"

@alvneiayu alvneiayu force-pushed the statusemptylasttransitiontime branch from b719026 to c5d0e90 Compare November 13, 2023 08:50
@alvneiayu
Copy link
Collaborator Author

hi @tewfik-ghariani

Could you help me to test it with the latest changes that I pushed it, please? I can not reproduce this error in the last version TBH.

thanks

Álvaro

@tewfik-ghariani
Copy link
Contributor

It works now, thank you so much!

2023/11/13 12:18:42 Starting sealed-secrets controller version: c5d0e90e8ad466af2f6253d3cb64d94896ac40f3
controller version: c5d0e90e8ad466af2f6253d3cb64d94896ac40f3

Updating playground-dev/mock-secret
Event(v1.ObjectReference{Kind:"SealedSecret", Namespace:"playground-dev", Name:"mock-secret",
 UID:"1465e8e6-0288-40ac-a8c4-c70e163ae15f", APIVersion:"bitnami.com/v1alpha1", 
ResourceVersion:"390849524", FieldPath:""}): 
type: 'Normal' reason: 'Unsealed' SealedSecret unsealed successfully
update suppressed, no changes in sealed secret spec of playground-dev/mock-secret

NAME                                 STATUS   SYNCED   AGE
mock-secret                                    True     4s

@alvneiayu alvneiayu merged commit c8fa1ad into bitnami-labs:main Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarcia-oss agarcia-oss agarcia-oss approved these changes

@tewfik-ghariani tewfik-ghariani tewfik-ghariani approved these changes

@alemorcuq alemorcuq Awaiting requested review from alemorcuq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error updating status of newly created SealedSecrets resources
3 participants
@alvneiayu @tewfik-ghariani @agarcia-oss